Merged
Conversation
Closed
1 task
Test Coverage Report
|
west-eastH
reviewed
Jul 2, 2025
| .password(passwordEncoder().encode(swaggerPassword)) | ||
| .roles("SWAGGER") | ||
| .build(); | ||
| return new InMemoryUserDetailsManager(user); |
Contributor
There was a problem hiding this comment.
이런건 어떻게 아셨어요..? 시큐리티 고수,,,
Contributor
Author
There was a problem hiding this comment.
ㅋㅋㅋ api 외부로 노출되면 안 된다고 해서..
| @Order(2) | ||
| public SecurityFilterChain filterChain(HttpSecurity http) throws Exception { | ||
| http | ||
| .securityMatcher(PermitAllPatterns) |
Contributor
There was a problem hiding this comment.
여기에 permitAllPatterns가 들어가면 저기에만 시큐리티 적용 아닌가요??
Contributor
Author
There was a problem hiding this comment.
securityMatcher에 있는 uri에 대해서 해당 필터 체인을 적용하겠다는 의미로 적었습니다!!!
(저거 추가 안하니깐 스웨거 요청도 다 저 필터 체인으로 걸리길래..추가했습니다)
west-eastH
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 연관된 이슈
📝 작업 내용 (주요 변경 사항)
💬 리뷰 요구사항
시큐리티에 requestMatchers 에 들어갈 uri 패턴들을 final 변수로 관리하면 좋을거 같아서 수정해봤는데 한번 보고 의견주세요!